Feat:[snsproject] 댓글 목록 UI 구현 및 댓글 데이터 추가 #33
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -21,6 +21,9 @@ data class BoardDTO( | |||
| val createUserName: String, | |||
| @SerializedName("createUserProfileFilePath") | |||
| val createUserProfileFilePath: String, | |||
| @SerializedName("commentList") | |||
| val commentList: List<CommentDTO> | |||
There was a problem hiding this comment.
🚫 [ktlint] standard:trailing-comma-on-declaration-site reported by reviewdog 🐶
Missing trailing comma before ")"
| @@ -21,6 +21,9 @@ data class BoardDTO( | |||
| val createUserName: String, | |||
| @SerializedName("createUserProfileFilePath") | |||
| val createUserProfileFilePath: String, | |||
| @SerializedName("commentList") | |||
| val commentList: List<CommentDTO> | |||
|
|
|||
There was a problem hiding this comment.
🚫 [ktlint] standard:no-blank-line-in-list reported by reviewdog 🐶
Unexpected blank line(s) in value parameter list
| @@ -32,7 +35,8 @@ data class BoardDTO( | |||
| profileImageUrl = this.createUserProfileFilePath, | |||
| content = contentParam.text, | |||
| userId = this.createUserId, | |||
| images = contentParam.images | |||
| images = contentParam.images, | |||
| comments = this.commentList.map { it.toDomainModel() } | |||
There was a problem hiding this comment.
🚫 [ktlint] standard:trailing-comma-on-call-site reported by reviewdog 🐶
Missing trailing comma before ")"
| import com.example.domain.model.Comment | ||
| import com.google.gson.annotations.SerializedName | ||
|
|
||
|
|
There was a problem hiding this comment.
🚫 [ktlint] standard:no-consecutive-blank-lines reported by reviewdog 🐶
Needless blank line(s)
| @SerializedName("createUserName") | ||
| val createUserName: String, | ||
| @SerializedName("profileImageUrl") | ||
| val profileImageUrl: String |
There was a problem hiding this comment.
🚫 [ktlint] standard:trailing-comma-on-declaration-site reported by reviewdog 🐶
Missing trailing comma before ")"
| val profileImageUrl: String | ||
| ) | ||
|
|
||
| fun CommentDTO.toDomainModel() : Comment { |
There was a problem hiding this comment.
🚫 [ktlint] standard:function-return-type-spacing reported by reviewdog 🐶
Unexpected whitespace
| val profileImageUrl: String | ||
| ) | ||
|
|
||
| fun CommentDTO.toDomainModel() : Comment { |
There was a problem hiding this comment.
🚫 [ktlint] standard:colon-spacing reported by reviewdog 🐶
Unexpected spacing before ":"
| id = id, | ||
| profileImageUrl = profileImageUrl, | ||
| text = comment, | ||
| username = createUserName |
There was a problem hiding this comment.
🚫 [ktlint] standard:trailing-comma-on-call-site reported by reviewdog 🐶
Missing trailing comma before ")"
| @@ -7,5 +7,6 @@ data class Board( | |||
| val images: List<String> = listOf(), | |||
| val userId: Long, | |||
| val username: String, | |||
| val profileImageUrl: String | |||
| val profileImageUrl: String, | |||
| val comments: List<Comment> | |||
There was a problem hiding this comment.
🚫 [ktlint] standard:trailing-comma-on-declaration-site reported by reviewdog 🐶
Missing trailing comma before ")"
| val id: Long, | ||
| val text: String, | ||
| val username: String, | ||
| val profileImageUrl: String? = null |
There was a problem hiding this comment.
🚫 [ktlint] standard:trailing-comma-on-declaration-site reported by reviewdog 🐶
Missing trailing comma before ")"
close #18
PR 템플릿