Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix abstract class implementation for fpga_interchange #1247

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

cbalint13
Copy link
Contributor

Hi folks,

This fixes a missing declaration for the fpga_interchange submodule.

The error was introduced in #1228 :

nextpnr/common/kernel/pybindings.cc: In function ‘nextpnr_fpga_interchange::Context* nextpnr_fpga_interchange::load_design_shim(std::string, ArchArgs)’:
BUILD/nextpnr/common/kernel/pybindings.cc:61:34: error: invalid new-expression of abstract class type ‘nextpnr_fpga_interchange::Context’
   61 |     Context *d = new Context(args);
      |                                  ^
In file included from BUILD/nextpnr/common/kernel/nextpnr.h:24,
                 from BUILD/nextpnr/common/kernel/pycontainers.h:29,
                 from BUILD/nextpnr/common/kernel/pybindings.h:30,
                 from BUILD/nextpnr/common/kernel/pybindings.cc:23:
BUILD/nextpnr/common/kernel/context.h:31:8: note:   because the following virtual functions are pure within ‘nextpnr_fpga_interchange::Context’:
   31 | struct Context : Arch, DeterministicRNG
      |        ^~~~~~~
In file included from BUILD/nextpnr/common/kernel/base_arch.h:27,
                 from BUILD/nextpnr/common/kernel/nextpnr.h:23:
BUILD/nextpnr/common/kernel/arch_api.h:86:22: note:     ‘nextpnr_fpga_interchange::IdString nextpnr_fpga_interchange::ArchAPI<R>::getWireConstantValue(nextpnr_fpga_interchange::WireId) const [with R = nextpnr_fpga_interchange::ArchRanges]’
   86 |     virtual IdString getWireConstantValue(WireId wire) const = 0;

@gatecat gatecat merged commit 7814f44 into YosysHQ:master Nov 23, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants