Merge pull request #59 from YotpoLtd/v1.3.8

v1.3.8
YotpoLtd · Apr 16, 2023 · c6717ed · c6717ed
2 parents f7b7746 + 2ab4a6a
commit c6717ed
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/Model/Api/Swell/Session/CouponManagement.php b/Model/Api/Swell/Session/CouponManagement.php
@@ -50,7 +50,7 @@ public function postCoupon()
                 $existingCodes = (string) $quote->getData("coupon_code");
                 $couponCodes = [$code];
 
-                if (isset($codesToRemove) && isset($existingCodes)) {
+                if ($codesToRemove && $existingCodes) {
                     $codesToRemove = (is_array($codesToRemove)) ? $codesToRemove : explode(",", strtoupper($codesToRemove));
                     $existingCodes = explode(",", strtoupper($existingCodes));
                     foreach ($existingCodes as $existingCode) {

diff --git a/Model/Api/Swell/Session/RemoveCodeManagement.php b/Model/Api/Swell/Session/RemoveCodeManagement.php
@@ -48,7 +48,7 @@ public function postRemoveCode()
                 $codesToRemove = $this->_yotpoHelper->getRequest()->getParam('swell_coupon_code_cancel', '');
                 $existingCodes = (string) $quote->getData("coupon_code");
                 $couponCodes = [];
-                if (isset($codesToRemove) && isset($existingCodes)) {
+                if ($codesToRemove && $existingCodes) {
                     $codesToRemove = (is_array($codesToRemove)) ? $codesToRemove : explode(",", strtoupper($codesToRemove));
                     $existingCodes = explode(",", strtoupper($existingCodes));
                     foreach ($existingCodes as $existingCode) {

diff --git a/composer.json b/composer.json
@@ -2,7 +2,7 @@
     "name": "yotpo/magento2-module-yotpo-loyalty",
     "description": "Magento 2 module for integration with Yotpo",
     "type": "magento2-module",
-    "version": "1.3.7",
+    "version": "1.3.8",
     "repositories": [{
         "type": "git",
         "url": "https://github.com/YotpoLtd/magento2-module-yotpo-loyalty"

diff --git a/etc/module.xml b/etc/module.xml
@@ -1,6 +1,6 @@
 <?xml version="1.0"?>
 <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
-    <module name="Yotpo_Loyalty" setup_version="1.3.7">
+    <module name="Yotpo_Loyalty" setup_version="1.3.8">
         <sequence>
 			<module name="Magento_Catalog" />
         </sequence>