Skip to content

Commit

Permalink
docs:
Browse files Browse the repository at this point in the history
fixed xref in whats-new.md
removed unused docs
  • Loading branch information
DennisDyallo committed Dec 17, 2024
1 parent b814659 commit cf4b0ed
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ Bug Fixes:

- The [PivSession.ChangeManagementKey](xref:Yubico.YubiKey.Piv.PivSession.ChangeManagementKey(Yubico.YubiKey.Piv.PivTouchPolicy)) method was incorrectly assuming Triple-DES was the default management key algorithm for FIPS keys. The SDK now verifies the management key alorithm based on key type and firmware version. ([#162](https://github.com/Yubico/Yubico.NET.SDK/pull/162))
- The SDK now correctly sets the IYubiKeyDeviceInfo property [IsSkySeries](xref:Yubico.YubiKey.IYubiKeyDeviceInfo.IsSkySeries) to True for YubiKey Security Key Series Enterprise Edition keys. ([#158](https://github.com/Yubico/Yubico.NET.SDK/pull/158))
- Exceptions are now caught when running [PivSession.Dispose](xref:Yubico.YubiKey.Piv.PivSession.Dispose). This fixes an issue where the Dispose method could not close the Connection in the event of a disconnected YubiKey. ([#104](https://github.com/Yubico/Yubico.NET.SDK/issues/104))
- Exceptions are now caught when running PivSession.Dispose. This fixes an issue where the Dispose method could not close the Connection in the event of a disconnected YubiKey. ([#104](https://github.com/Yubico/Yubico.NET.SDK/issues/104))
- A dynamic DLL resolution based on process architecture (x86/x64) has been implemented for NativeShims.dll. This fixes a reported issue with the NativeShims.dll location for 32-bit processes. ([#154](https://github.com/Yubico/Yubico.NET.SDK/pull/154))

Deprecations:
Expand Down
6 changes: 0 additions & 6 deletions Yubico.YubiKey/src/Yubico/YubiKey/Piv/PivSession.cs
Original file line number Diff line number Diff line change
Expand Up @@ -224,12 +224,6 @@ public PivSession(IYubiKeyDevice yubiKey, ScpKeyParameters? keyParameters = null
/// </remarks>
public Func<KeyEntryData, bool>? KeyCollector { get; set; }

/// <summary>
/// When the PivSession object goes out of scope, this method is called.
/// It will close the session. The most important function of closing a
/// session is to "un-authenticate" the management key and "un-verify"
/// the PIN.
/// </summary>
protected override void Dispose(bool disposing)
{
if (disposing)
Expand Down

0 comments on commit cf4b0ed

Please sign in to comment.