Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure IsSkySeries property is carried forward for 'merged' devices #158

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

AaFortner
Copy link
Contributor

Description

Ensures that 'merged' devices carry forward the IsSkySeries property during device discovery in YubiKeyDeviceListener

Fixes: #156

Type of change

  • Refactor (non-breaking change which improves code quality or performance)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

Added a new integration test: YubiKeyDeviceListenerTests.KeyArrived_SkyEe_IsSkySeriesIsTrue

Test configuration:

  • Firmware version: 5.7.1
  • Yubikey model: A NFC SKY EE

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have run dotnet format to format my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link

github-actions bot commented Nov 7, 2024

Test Results: Windows

    2 files      2 suites   4s ⏱️
3 703 tests 3 703 ✅ 0 💤 0 ❌
3 705 runs  3 705 ✅ 0 💤 0 ❌

Results for commit b6d9cbf.

Copy link

github-actions bot commented Nov 7, 2024

Test Results: Ubuntu

    2 files      2 suites   10s ⏱️
3 695 tests 3 695 ✅ 0 💤 0 ❌
3 697 runs  3 697 ✅ 0 💤 0 ❌

Results for commit b6d9cbf.

Copy link

github-actions bot commented Nov 7, 2024

Test Results: MacOS

    2 files      2 suites   4s ⏱️
3 695 tests 3 695 ✅ 0 💤 0 ❌
3 697 runs  3 697 ✅ 0 💤 0 ❌

Results for commit b6d9cbf.

Copy link

github-actions bot commented Nov 7, 2024

Code Coverage

Package Line Rate Branch Rate Complexity Health
Yubico.Core 43% 32% 4221
Yubico.YubiKey 50% 47% 19164
Summary 49% (32204 / 66078) 44% (8200 / 18591) 23385

Minimum allowed line rate is 40%

Copy link
Collaborator

@DennisDyallo DennisDyallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @AaFortner !

@DennisDyallo DennisDyallo added the bug Something isn't working label Nov 8, 2024
@DennisDyallo DennisDyallo merged commit 655d893 into develop Nov 8, 2024
12 checks passed
@DennisDyallo DennisDyallo deleted the bugfix/1407-ee-isskyseries branch November 8, 2024 09:52
This was referenced Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

[BUG] Device info for SKY EE keys doesn't have IsSkySeries set when announced via YubiKeyDeviceListener
2 participants