Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Removed TDES as default assumption for PivSession.PinOnly #167

Merged
merged 5 commits into from
Dec 17, 2024

Conversation

DennisDyallo
Copy link
Collaborator

@DennisDyallo DennisDyallo commented Dec 17, 2024

Description

The PivSession.PinOnly class was incorrectly assuming TripleDes as management key algorithm.
Related work: #162

Fixes #160

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Copy link

github-actions bot commented Dec 17, 2024

Test Results: Windows

    2 files      2 suites   5s ⏱️
3 741 tests 3 741 ✅ 0 💤 0 ❌
3 743 runs  3 743 ✅ 0 💤 0 ❌

Results for commit 4e5a685.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 17, 2024

Test Results: Ubuntu

    2 files      2 suites   9s ⏱️
3 733 tests 3 733 ✅ 0 💤 0 ❌
3 735 runs  3 735 ✅ 0 💤 0 ❌

Results for commit 4e5a685.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 17, 2024

Test Results: MacOS

    2 files      2 suites   5s ⏱️
3 733 tests 3 733 ✅ 0 💤 0 ❌
3 735 runs  3 735 ✅ 0 💤 0 ❌

Results for commit 4e5a685.

♻️ This comment has been updated with latest results.

@DennisDyallo DennisDyallo changed the title [fix] Removed TDES as default assumption [fix] Removed TDES as default assumption for PivSession.PinOnly Dec 17, 2024
Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
Yubico.Core 44% 32% 4311
Yubico.YubiKey 49% 46% 19671
Summary 48% (32918 / 68499) 43% (8245 / 18990) 23982

Minimum allowed line rate is 40%

@DennisDyallo DennisDyallo merged commit 5dd512e into develop Dec 17, 2024
12 checks passed
@DennisDyallo DennisDyallo deleted the fix/tdes-default-key branch December 17, 2024 15:37
This was referenced Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants