Handle empty queue after K_CF_RUN_LOOP_RUN_HANDLED_SOURCE
#245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Occassionally CFRunLoopInMode() returns K_CF_RUN_LOOP_RUN_HANDLED_SOURCE even though the _hid_read_callback() has not been invoked, resulting in reading from an empty queue. We can handle this by re-running the run loop with a retry mechanism.
dainnilsson
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occassionally
CFRunLoopInMode()returnsK_CF_RUN_LOOP_RUN_HANDLED_SOURCEeven though the_hid_read_callback()has not been invoked, resulting in reading from an empty queue. We can handle this by re-running the run loop with a retry mechanism.