Simplify msys2 build and fully leverage vcpkg for MSVC #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proposed changes streamline building on Windows using MSYS2 ecosystem as well as MSVC. For the latter, instead of manually installing dependencies with vcpkg, we can use a manifest file. I do not use vcpkg on other platforms, so I am not sure whether there might be some conflicts with automatically setting CMAKE_TOOLCHAIN_FILE in CMakeLists.txt if VCPKG_ROOT environment variable is set and whether it should be safeguarded with WIN32 conditional.
Also, I'm not sure what is the situation with mingw as I see some comments hinting at it like in lib/internal.c . However, those seem a) outdated, b) it is a pain to build without proposed changes (see msys2/MINGW-packages#22437).