Check max message size against firmware version #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aveenismail
force-pushed
the
max_msg_size
branch
from
6ebecda
to
eaf9ebd
Compare
qpernil
requested changes
Aug 29, 2024
There was a problem hiding this comment.
Refactor other places that call yh_util_get_device_info, since we now have it cached. Also, in yh_connect return the value from yh_util_get_device_info (and return the previous rc if it fails). We should also cache the other info we can get from this call (specifically, the algoritm list).
aveenismail
force-pushed
the
max_msg_size
branch
from
0db548c
to
6dbfa28
Compare
qpernil
approved these changes
Aug 30, 2024
aveenismail
force-pushed
the
max_msg_size
branch
2 times, most recently
from
969cec4
to
35ede0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.