Fix asym_wrap_test on 32-bit architectures #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`C_WrapKey` and `C_UnwrapKey` use `CK_ULONG` for the wrapped key size, which isn't the same as `size_t` on all architectures. This caused "passing argument ... from incompatible pointer type" errors on Debian i386.
|
The test failures don't seem to have anything to do with my changes; I'd appreciate somebody more knowledgeable about them having a look at those. |
|
The errors are not related to your fix, just that external PRs don't have access to github secrets. |
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C_WrapKeyandC_UnwrapKeyuseCK_ULONGfor the wrapped key size, which isn't the same assize_ton all architectures. This caused "passing argument ... from incompatible pointer type" errors on Debian i386.