-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grab the files from the RSS Bridge master directly #54
Closed
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
a7f3082
Merge pull request #44 from YunoHost-Apps/testing
yalh76 e75ce1a
Merge pull request #46 from YunoHost-Apps/testing
yalh76 1b85601
Merge pull request #48 from YunoHost-Apps/testing
JimboJoe fcbdba8
Merge pull request #49 from YunoHost-Apps/testing
ericgaspar 0d12572
Move to the Master branch
tio-trom File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| SOURCE_URL=https://github.com/RSS-Bridge/rss-bridge/archive/refs/tags/2022-06-14.tar.gz | ||
| SOURCE_SUM=88daee9604adcb2193ee771c260bcf422a806c284a46c4f263d42cf323d42fe1 | ||
| SOURCE_URL=https://github.com/RSS-Bridge/rss-bridge/archive/refs/heads/master.zip | ||
| SOURCE_SUM=c39b875e1b2c047662b06366f63a6888f6fba3c5146e2034433f06a7e40594d3 | ||
| SOURCE_SUM_PRG=sha256sum | ||
| SOURCE_FORMAT=tar.gz | ||
| SOURCE_FORMAT=zip | ||
| SOURCE_IN_SUBDIR=true | ||
| SOURCE_FILENAME= | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest to use a source archive for the specific commit number (I took the latest commit in the
masterbranch at the moment). This way it should be deterministic between multiple installs and should download the same sources until the link will be changed again.Also, this change would require a change of the package version postfix at least
~ynh3..~ynh4to notify users that package is changed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we change the commit version, the whole version name has to change.
I believe this PR will bring a newer version anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, then since Bridge developers are using the dates, it might be a date of the commit was used in update, e.g.
2023.03.21.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest as well to point to a specific commit archive, and change the package version each. An example in the ttrss package: https://github.com/YunoHost-Apps/ttrss_ynh/blob/master/manifest.toml#L43
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This issue is that it's a burden to maintain and test.
But if no new releases are going to be made, then we might have no choice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is the SearxNG managed? It seems to push updates every other day.