Fix upgrade from previous versions #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following the documentation here: https://doc.yunohost.org/en/packaging_apps_helpers_v2.1#ynh-setup-source
|
Please never try to merge into master :) |
|
!testme |
|
Alrighty! |
|
Living in the past, are we? 🐮👁️ |
oh sorry! I didn't know, is there a place where I can read more contributing guidelines? Anyway, thank you for checking the PR immediately! :) |
|
Ok then it seems to work for the basic CI tests. |
|
Upgraded to 2.5.4-ynh11 from an installation working thanks to setting it to a previous php-mysql + setting user with a workaround. |
What do you mean ? |
|
Based on feedback on the forum, it looks ok to merge soon. |
lapineige
added a commit
that referenced
this pull request
Jan 5, 2025
* Update manifest.toml * Auto-update READMEs * Update manifest.toml * Auto-update READMEs * Fix upgrade from previous versions (#229) * Move patches to the right folder Following the documentation here: https://doc.yunohost.org/en/packaging_apps_helpers_v2.1#ynh-setup-source * Bump version --------- Co-authored-by: lapineige <[email protected]> * Auto-update READMEs --------- Co-authored-by: yunohost-bot <[email protected]> Co-authored-by: Matteo Giaccone <[email protected]> Co-authored-by: lapineige <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When updating the YunoHost patches were not applied and so the installation wasn't working properly, for example the login wasn't working as expected.
Existing reports:
The existing conversation in the forum: https://forum.yunohost.org/t/cannot-log-in-with-latest-wallabag-update/31073
Solution
Following the documentation https://doc.yunohost.org/en/packaging_apps_helpers_v2.1#ynh-setup-source (open the toggle for the full description) I moved the patches to the right folder:
So the patches are correctly applied and SSO is working again.
PR Status
Automatic tests
Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)