-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to go mod and latest go, improve build #346
base: 2.8.0-dev
Are you sure you want to change the base?
Conversation
be1ae42
to
c165467
Compare
Hmmm, interested to see the differences between this and #270 |
@thebeline There are some minor differences in tags - I didn't need to add the Here's the Makefile diff between #270 and #346: https://github.com/Z-Bolt/OctoScreen/compare/cddd776..c165467#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52 |
15be7ea
to
3580f83
Compare
c16cd04
to
05c286d
Compare
Changed target do Update: Resolved conflicts and rebased to current |
4cd9721
to
eefcbee
Compare
@the-ress Thanks for the contribution. Just a heads up here... this PR probably won't be going into 2.8 (there are over 1,200 changes w/this PR, and I'm close to releasing). Also, for releases after 2.8.x, I'm considering dropping GO and building OctoScreen as an Electron application using Typescript. I'll need to spike on this first, but the more I use GO and GTK, the less I like it. |
That's... unexpected. I'm worried it'll tank the performance, especially on boards like RPi Zero 2. Go is actually why I chose OctoScreen over OctoDash (OctoDash is using JS+HTML and was way too slow when I tried it.) Edit: It's even noted in README:
|
Most of that comes from the deleted |
e514a99
to
4d3dbc4
Compare
I will be keeping that in mind. It's not a sure thing, and I will be spiking on it later before making a decision. |
22936a1
to
c5d5599
Compare
c5d5599
to
238cbbb
Compare
I plan to contribute some fixes, but first I wanted to make the building and development experience a bit more pleasant.
Main changes:
Necessary changes for the above:
G_FORMAT_SIZE_BITS
gotk3/gotk3#811Aside from the gotk3-related changes, I didn't touch any
.go
files so I hope it won't collide with any other work that's going on. (Bulk of the changed files is the deletedvendors
folder.)I also tried merging these changes with 2.8 - there's only 1 very trivial conflict and it compiles fine.