zebra_script: update to new zcash_script callback API #15320
Triggered via pull request
June 13, 2024 22:49
conradoplg
conradoplg
synchronize
#8566
Status
Success
Total duration
17s
Artifacts
–
release-drafter.yml
on: pull_request_target
update_release_draft
6s
Annotations
3 errors
|
usage of a legacy numeric constant:
zebra-chain/src/work/difficulty/arbitrary.rs#L52
error: usage of a legacy numeric constant
--> zebra-chain/src/work/difficulty/arbitrary.rs:52:13
|
52 | (1..std::u128::MAX).prop_map(Work).boxed()
| ^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
help: use the associated constant instead
|
52 | (1..u128::MAX).prop_map(Work).boxed()
| ~~~~~~~~~
|
|
usage of a legacy numeric method:
zebra-chain/src/sapling/keys.rs#L94
error: usage of a legacy numeric method
--> zebra-chain/src/sapling/keys.rs:94:31
|
94 | assert!(tag[i] != u8::max_value());
| ^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
= note: `-D clippy::legacy-numeric-constants` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::legacy_numeric_constants)]`
help: use the associated constant instead
|
94 | assert!(tag[i] != u8::MAX);
| ~~~
|
|
used unwrap or expect in a function that returns result or option:
zebra-chain/src/primitives/zcash_primitives.rs#L152
error: used unwrap or expect in a function that returns result or option
--> zebra-chain/src/primitives/zcash_primitives.rs:152:5
|
152 | / fn try_from(trans: &Transaction) -> Result<Self, Self::Error> {
153 | | let network_upgrade = match trans {
154 | | Transaction::V5 {
155 | | network_upgrade, ..
... |
166 | | )
167 | | }
| |_____^
|
= help: unwrap and expect should not be used in a function that returns result or option
note: potential non-recoverable error(s)
--> zebra-chain/src/primitives/zcash_primitives.rs:165:13
|
165 | network_upgrade.branch_id().expect("V5 txs have branch IDs"),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_in_result
= note: `-D clippy::unwrap-in-result` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::unwrap_in_result)]`
|