Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add(test): Add serialized NU5 blocks to test vectors #9098

Merged
merged 34 commits into from
Jan 15, 2025
Merged

add(test): Add serialized NU5 blocks to test vectors #9098

merged 34 commits into from
Jan 15, 2025

Conversation

upbqdn
Copy link
Member

@upbqdn upbqdn commented Dec 21, 2024

Motivation

Close #2409, #9090 and #9088.

Solution

Tests

  • Remove unneeded test for fake V5 txs.
  • Use real V5 txs where appropriate. This uncovered some malfunctioning tests, for example 34e985b.
  • Fix failing tests. This turned out to be much more work than I expected.
  • Use Network::iter instead of only Mainnet txs.

Follow-up Work

PR Author's Checklist

  • The PR name will make sense to users.
  • The PR provides a CHANGELOG summary.
  • The solution is tested.
  • The documentation is up to date.
  • The PR has a priority label.

PR Reviewer's Checklist

  • The PR Author's checklist is complete.
  • The PR resolves the issue.

upbqdn added 27 commits December 13, 2024 09:50
@upbqdn
Add serialized Mainnet blocks for tests
7e15762
@upbqdn
Add Sapling anchors
f1f83ac
@upbqdn
Add Mainnet Orchard anchors
9c8058f
@upbqdn
Remove wrong Testnet NU5 blocks
fe13db8
@upbqdn
Add Testnet blocks with V5 txs to test vectors
bc759c7
@upbqdn
Move the Sapling treestate
d0d9e96
@upbqdn
Add Sapling & Orchard anchors
e1e0162
@upbqdn
Remove unneeded test for fake V5 txs
7228929 
We don't need this test anymore since we have real V5 txs now.
@upbqdn
Add has_transparent_inputs to Transaction
35513d0
@upbqdn
Fix v5_with_sapling_spends test
e6422b1
@upbqdn
Fix binding_signatures test
34e985b
@upbqdn
Refactor block test vectors
883fb21
@upbqdn
Use real V5 txs instead of fake ones
d3f28b2
@upbqdn
Fix v5_transaction_is_rejected_before_nu5 test
1f15388
@upbqdn
Fix v5_tx_is_accepted_after_nu5_activation test
b83e826
@upbqdn
Fix v5_tx_with_no_outputs_fails_validation test
6108571
@upbqdn
Move v5_tx_with_no_outputs_fails_validation test
6c17f8d
@upbqdn
Fix v5_tx_with_no_inputs_fails_verification test
72678c0
@upbqdn
Fix v5_tx_with_orchard_actions_has_inputs.. test
c1393af
@upbqdn
Fix v5_coinbase_tx_without_spends_flag_passes
dfb2d9e
@upbqdn
Simplify orchard imports
3437af6
@upbqdn
Fix v5_tx_with_orchard_actions_has_flags test
363bf3a
@upbqdn
Fix v5_coinbase_tx_with_enable_spends_fails
7ac677f
@upbqdn
Fix v5_tx_with_duplicate_orchard_action test
9327beb
@upbqdn
Fix coinbase_outputs_are_decryptable_for_v5
27f9ed7
@upbqdn
Fix shielded_outputs_are_not_decryptable_for_v5
e419e3b
@upbqdn
Use Network::iter instead of Mainnet
2832612
@upbqdn upbqdn added C-testing Category: These are tests P-Medium ⚡ labels Dec 21, 2024
@upbqdn upbqdn self-assigned this Dec 21, 2024
@upbqdn upbqdn requested a review from oxarbitrage December 21, 2024 00:32
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Dec 21, 2024
@upbqdn upbqdn removed the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Dec 21, 2024
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Dec 21, 2024
@upbqdn upbqdn removed the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Dec 21, 2024
@mpguerra mpguerra requested review from arya2 and removed request for oxarbitrage January 8, 2025 15:12
arya2
arya2 previously approved these changes Jan 11, 2025
View reviewed changes
Copy link
Contributor

@arya2 arya2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you for these changes.

I left a few suggestions, none of them are blockers if you'd like this to merge as-is.

zebra-consensus/src/transaction/tests.rs Show resolved Hide resolved
zebra-consensus/src/transaction/tests.rs Outdated Show resolved Hide resolved
zebra-consensus/src/transaction/tests.rs Outdated Show resolved Hide resolved
zebra-consensus/src/transaction/tests.rs Outdated Show resolved Hide resolved
zebra-test/src/vectors/block.rs Show resolved Hide resolved
This was linked to issues Jan 13, 2025
Add serialized blocks with V5 txs containing Orchard actions to test vectors #9088
Closed
Testnet NU5 transition period has wrong blocks in test vectors #9090
Closed
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Jan 13, 2025
@arya2
Copy link
Contributor

arya2 commented Jan 15, 2025

@Mergifyio update

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 15, 2025

update

✅ Branch has been successfully updated

mergify bot added a commit that referenced this pull request Jan 15, 2025
@mergify
Merge of #9098
bd24c4f
@mergify mergify bot mentioned this pull request Jan 15, 2025
Closed
@mergify mergify bot merged commit 82c23f3 into main Jan 15, 2025
162 checks passed
@mergify mergify bot deleted the add-v5-txs branch January 15, 2025 11:31
This was referenced Jan 15, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arya2 arya2 arya2 approved these changes

Assignees

@upbqdn upbqdn

Labels
C-testing Category: These are tests C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG P-Medium ⚡
Projects
None yet
Milestone
No milestone
2 participants
@upbqdn @arya2