refactor(workflows): avoid using cached states for release instances #9137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Renamed `no_cached_disk` input to `need_cached_disk` in `cd-deploy-nodes-gcp.yml` to clarify its purpose. - Adjusted conditional logic for cached disk usage based on event types (release vs. non-release) in `cd-deploy-nodes-gcp.yml`. - Removed the environment strategy matrix from `sub-deploy-integration-tests-gcp.yml` to simplify the workflow configuration. - Enhanced comments for better clarity on caching and environment handling across workflows.
gustavovalverde
added
C-bug
gustavovalverde
requested review from
oxarbitrage
and removed request for
a team
github-actions
bot
added
the
C-trivial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We don't need the complexity of cached states in our long-lived instances, as we'll be using the same state across releases (this will also test the upgrades will work as expected).
This will also fix an regression in our main branch, caused by #9003
Solution
no_cached_diskinput toneed_cached_diskincd-deploy-nodes-gcp.ymlto clarify its purpose.cd-deploy-nodes-gcp.yml.sub-deploy-integration-tests-gcp.ymlto avoid creating cached states in another environmentsFollow-up Work
PR Author's Checklist
PR Reviewer's Checklist