Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respond to getblockchaininfo with genesis block when empty state #9138

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

elijahhampton
Copy link
Contributor

Motivation

A lightwalletd test fails for getblockchaininfo when the state is empty. This PR refactors the rpc request to return the genesis block.

Specifications & References

Solution

Adds a test for returning the genesis state in prop.rs. Refactors getblockchaininfo rpc to return the genesis block if TipPoolValues request fails.

Tests

Follow-up Work

PR Author's Checklist

  • [X ] The PR name will make sense to users.
  • [X ] The PR provides a CHANGELOG summary.
  • [X ] The solution is tested.
  • The documentation is up to date.
  • The PR has a priority label.

PR Reviewer's Checklist

  • The PR Author's checklist is complete.
  • The PR resolves the issue.

@elijahhampton elijahhampton requested a review from a team as a code owner January 17, 2025 21:35
@elijahhampton elijahhampton requested review from oxarbitrage and removed request for a team January 17, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant