make sure #slideshowViewport is properly aligned #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can confirm that this is a real issue. When using iron-pages or any similar component/behavior and it's not the first page to render it mis-aligns the viewport. I got around the problem by toggling the vertical property to trigger the change event. While this works, it introduces an issue with the responsiveWidth not triggering the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a stepper is not visible on its first render (e.g. rendered in an inactive paper-tab), the
topposition of#slideshowViewportis0. The content of the slideshow hence overlap with stepper labels.This PR makes sure we recalculate slideshowViewport' top position on resize.