Skip to content

Commit

Permalink
Merge pull request #15 from ghutchis/clang-tidy-11
Browse files Browse the repository at this point in the history
Update Dockerfile, scripts to allow clang-tidy-11 from focal
  • Loading branch information
ZedThree authored Apr 30, 2021
2 parents 3677b43 + 22e0d6a commit f936872
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 5 deletions.
1 change: 1 addition & 0 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ RUN apt update && \
clang-tidy-8 \
clang-tidy-9 \
clang-tidy-10 \
clang-tidy-11 \
python3 python3-pip && \
pip3 install --upgrade pip && \
pip3 install -r requirements.txt
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,8 @@ at once, so `clang-tidy-review` will only attempt to post the first
should be relative to `GITHUB_WORKSPACE` (the default place where your
repository is cloned)
- default: `'.'`
- `clang_tidy_version`: Version of clang-tidy to use; one of 6.0, 7, 8, 9, 10
- default: '10'
- `clang_tidy_version`: Version of clang-tidy to use; one of 6.0, 7, 8, 9, 10, 11
- default: '11'
- `clang_tidy_checks`: List of checks
- default: `'-*,performance-*,readability-*,bugprone-*,clang-analyzer-*,cppcoreguidelines-*,mpi-*,misc-*'`
- `include`: Comma-separated list of files or patterns to include
Expand Down
4 changes: 2 additions & 2 deletions action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ inputs:
default: '.'
required: false
clang_tidy_version:
description: 'Version of clang-tidy to use; one of 6.0, 7, 8, 9, 10'
default: '10'
description: 'Version of clang-tidy to use; one of 6.0, 7, 8, 9, 10, 11'
default: '11'
required: false
clang_tidy_checks:
description: 'List of checks'
Expand Down
2 changes: 1 addition & 1 deletion review.py
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ def main(
parser.add_argument("--repo", help="Repo name in form 'owner/repo'")
parser.add_argument("--pr", help="PR number", type=int)
parser.add_argument(
"--clang_tidy_binary", help="clang-tidy binary", default="clang-tidy-9"
"--clang_tidy_binary", help="clang-tidy binary", default="clang-tidy-11"
)
parser.add_argument(
"--build_dir", help="Directory with compile_commands.json", default="."
Expand Down

0 comments on commit f936872

Please sign in to comment.