Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gg18 #18

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

gg18 #18

wants to merge 5 commits into from

Conversation

omershlo
Copy link
Contributor

@omershlo omershlo commented Apr 9, 2019 •
edited
Loading

features:

  • replace Lindell17 with GG18
  • legacy support for Lindell17 generated addresses
  • the API for legacy remains the same, the CLI use wallet-legacy and send-legacy

Open items (non blockers):

  • the code uses new branch of KMS repo (PR: Gg18 support kms-secp256k1#18) and needs to be updated once this PR is merged
  • write local server and client tests (the code was tested with testnet - it was slow and painful)
  • add recid to gg18 signing

@omershlo omershlo requested a review from gbenattar April 9, 2019 17:35
@omershlo omershlo mentioned this pull request May 17, 2019
Closed
@gbenattar
Copy link
Contributor

@omershlo is it still relevant? If yes, we need to fix conflicts and make sure @oleiba is on top of it. He will review the cryptography and I will review the overall change (without checking the correctness of the math).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbenattar gbenattar Awaiting requested review from gbenattar

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omershlo @gbenattar