-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type safety: implement enums #1425
base: master
Are you sure you want to change the base?
Type safety: implement enums #1425
Conversation
…ithub.com/setlife-network/zeus into or/issue-1262/type-safety-implement-enums
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Channel listing view is breaking. Need to fix that.
In ChannelItem.tsx and Tag.tsx, We are importing Status
from ChannelsPane.tsx that we have removed from there; it should be imported from enums,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to resolve branch conflicts as well.
389e385
to
8e7e1fa
Compare
@@ -0,0 +1,188 @@ | |||
#!/usr/bin/env sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we remove this file @Ovifer13?
1c682d4
to
2068ca3
Compare
Description
Relates to issue: ZEUS-1262
Implement an enum file where all enum variables are stored and can be used in all components.
This pull request is categorized as a:
Checklist
yarn run tsc
and made sure my code compiles correctlyyarn run lint
and made sure my code didn’t contain any problematic patternsyarn run prettier
and made sure my code is formatted correctlyyarn run test
and made sure all of the tests passTesting
If you modified or added a utility file, did you add new unit tests?
I have tested this PR on the following platforms (please specify OS version and phone model/VM):
I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):
Locales
Third Party Dependencies and Packages
yarn
after this PR is merged inpackage.json
andyarn.lock
have been properly updatedOther: