Inbound routing fees #2354
Open
Inbound routing fees #2354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubhamkmr04
force-pushed
the
shubham/inbound-routing-fees
branch
from
e6d37b7
to
9d46600
Compare
shubhamkmr04
force-pushed
the
shubham/inbound-routing-fees
branch
from
8f24495
to
b6b0c99
Compare
…inbound fees input
kaloudis
reviewed
Sep 18, 2024
kaloudis
reviewed
Sep 18, 2024
shubhamkmr04
force-pushed
the
shubham/inbound-routing-fees
branch
from
9f98b0c
to
69bbd25
Compare
kaloudis
reviewed
Sep 19, 2024
models/ChannelInfo.ts
Outdated
| @@ -6,6 +6,8 @@ interface RoutingPolicy { | |||
| min_htlc: string; | |||
| fee_base_msat: string; | |||
| fee_rate_milli_msat: string; | |||
| inbound_fee_base_msat: string; | |||
| inbound_fee_rate_milli_msat: string; | |||
There was a problem hiding this comment.
let's add ? to these two new fields as older nodes may not have them
kaloudis
reviewed
Sep 19, 2024
| feeRateInbound={`${ | ||
| Number(policy.inbound_fee_rate_milli_msat) / | ||
| 10000 | ||
| }`} |
There was a problem hiding this comment.
for these two, let's check to see if they exist or return null - otherwise there will be cases here where it returns NaN
There was a problem hiding this comment.
would it be better to return 0 instead of null ?
kaloudis
requested changes
Sep 19, 2024
components/FeeBreakdown.tsx
Outdated
| ) / 10000 | ||
| }%`} | ||
| sensitive | ||
| /> |
There was a problem hiding this comment.
these two should only be displayed if supportInboundFees
shubhamkmr04
force-pushed
the
shubham/inbound-routing-fees
branch
from
69bbd25
to
7d48ef4
Compare
shubhamkmr04
force-pushed
the
shubham/inbound-routing-fees
branch
from
9aab0d7
to
e029ec1
Compare
…i only for the nodes that support it.
kaloudis
requested changes
Sep 19, 2024
| @@ -24,6 +24,8 @@ interface SetFeesFormProps { | |||
| SettingsStore?: SettingsStore; | |||
| baseFee?: string; | |||
| feeRate?: string; | |||
| baseFeeInbound: string; | |||
| feeRateInbound: string; | |||
| base_fee_msat: base_fee_msat_inbound, | ||
| fee_rate_ppm: `${Number(fee_rate_inbound) * 10000}` | ||
| } | ||
| }), |
There was a problem hiding this comment.
if you're gonna go with this approach, be sure to update it in the LNC backend file as well - otherwise you can do something similar in the store
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relates to issue: ZEUS-2185
We want to implement the ability to set the inbound routing fees
This pull request is categorized as a:
Checklist
yarn run tscand made sure my code compiles correctlyyarn run lintand made sure my code didn’t contain any problematic patternsyarn run prettierand made sure my code is formatted correctlyyarn run testand made sure all of the tests passTesting
If you modified or added a utility file, did you add new unit tests?
I have tested this PR on the following platforms (please specify OS version and phone model/VM):
I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):
Locales
Third Party Dependencies and Packages
yarnafter this PR is merged inpackage.jsonandyarn.lockhave been properly updatedOther: