Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZEUS-2106: LND: spend entire UTXO in on-chain TX #2416

Merged
merged 6 commits into from
Sep 24, 2024

Conversation

kaloudis
Copy link
Contributor

@kaloudis kaloudis commented Sep 16, 2024

Description

Relates to issues: ZEUS-790, ZEUS-1433, ZEUS-2106

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (CLNRest)
  • LndHub
  • [DEPRECATED] Core Lightning (c-lightning-REST)
  • [DEPRECATED] Core Lightning (Spark)
  • [DEPRECATED] Eclair

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis kaloudis added LND Issues specific to LND nodes Coin control labels Sep 16, 2024
@kaloudis kaloudis added this to the v0.9.1 milestone Sep 16, 2024
@kaloudis
Copy link
Contributor Author

kaloudis commented Sep 16, 2024

Remaining tests:

  • LNC interface
  • Embedded LND interface
  • UTXOs from external accounts

@kaloudis kaloudis force-pushed the zeus-2106 branch 3 times, most recently from 4ab06eb to f743d23 Compare September 21, 2024 21:04
@kaloudis
Copy link
Contributor Author

It doesn't appear we can spend full UTXOs from external accounts, yet, as we hit unable to fetch+lock wallet utxos: unknown utxo: NewSubMap: missing key

Will create an issue on the LND repo to track, shortly

@kaloudis
Copy link
Contributor Author

It doesn't appear we can spend full UTXOs from external accounts, yet, as we hit unable to fetch+lock wallet utxos: unknown utxo: NewSubMap: missing key

Will create an issue on the LND repo to track, shortly

ZEUS issue: #2435
LND issue: lightningnetwork/lnd#9130

Copy link
Contributor

@shubhamkmr04 shubhamkmr04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@kaloudis kaloudis merged commit d8945fa into ZeusLN:master Sep 24, 2024
3 checks passed
@kaloudis kaloudis deleted the zeus-2106 branch September 24, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Coin control LND Issues specific to LND nodes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants