put invalid question name in error

ZeusWPI · Aug 23, 2024 · 60ea5f1 · 60ea5f1
1 parent 4261d06
commit 60ea5f1
Showing 1 changed file with 8 additions and 10 deletions.
diff --git a/zns/src/message.rs b/zns/src/message.rs
@@ -20,18 +20,16 @@ impl Message {
     }
 
     pub fn check_authoritative(&self, auth_zone: &LabelString) -> Result<(), ZNSError> {
-        let authoritative = self.question.iter().all(|question| {
+        for question in &self.question {
             let zlen = question.qname.len();
-            zlen >= auth_zone.len()
-                && vec_equal(&question.qname[zlen - auth_zone.len()..], auth_zone)
-        });
-
-        if !authoritative {
-            return Err(ZNSError::Refused {
-                message: "Not authoritative".to_string(),
-            });
+            if !(zlen >= auth_zone.len()
+                && vec_equal(&question.qname[zlen - auth_zone.len()..], auth_zone))
+            {
+                return Err(ZNSError::Refused {
+                    message: format!("Not authoritative for: {}", question.qname.join(".")),
+                });
+            }
         }
-
         Ok(())
     }
 }