vingo: get scan key from env

ZeusWPI · Oct 4, 2024 · 39e0853 · 39e0853
1 parent c0d0776
commit 39e0853
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/vingo/dev.env b/vingo/dev.env
@@ -1,10 +1,11 @@
-DEBUG_LOGIN="TRUE"
+DEBUG_LOGIN="FALSE"
 DEVELOPMENT="TRUE"
 
 POSTGRES_CONNECTION_STRING="postgres://postgres:[email protected]/zess?sslmode=disable"
-ZAUTH_URL="https://zauth.zeus.gent/"
+ZAUTH_URL="https://zauth.zeus.gent"
 ZAUTH_CALLBACK_PATH="http://localhost:4000/api/auth/callback"
 FRONTEND_URL="http://localhost:5173/"
 
 ZAUTH_CLIENT_ID="tomtest"
 ZAUTH_CLIENT_SECRET="blargh"
+SCAN_KEY="bad_key"
diff --git a/vingo/src/routes/scans.rs b/vingo/src/routes/scans.rs
@@ -1,3 +1,5 @@
+use std::{env, sync::LazyLock};
+
 use crate::{
     entities::{prelude::*, *},
     AppState,
@@ -17,7 +19,8 @@ use super::util::{
     session::{get_season, get_user},
 };
 
-const SCAN_KEY: &str = "bad_key";
+const SCAN_KEY: LazyLock<String> =
+    LazyLock::new(|| env::var("SCAN_KEY").expect("SCAN_KEY not present"));
 
 pub async fn get_for_current_user(
     session: Session,
@@ -43,7 +46,7 @@ pub async fn add(state: State<AppState>, body: String) -> ResponseResult<String>
     let (serial, key) = body
         .split_once(';')
         .ok_or((StatusCode::BAD_REQUEST, "invalid format: serial;key"))?;
-    if key != SCAN_KEY {
+    if key != SCAN_KEY.to_string() {
         Err((StatusCode::UNAUTHORIZED, "invalid key"))?
     }