Fix deleting clients #260
Merged
Fix deleting clients #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rien
force-pushed
the
fix/delete-client
branch
from
d77cd20
to
00fa4d2
Compare
FKD13
approved these changes
Oct 26, 2023
Not urgently at the moment. But might be nice? The ability to disable users already gets us a long way |
xerbalind
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleting clients with sessions would throw an error because of a constraint violation:
This PR adds a test to reproduce this issue and fixes the issue by adding
ON DELETE CASCADEto the foreign key constraint. This causes a delete on a client tot delete all associated sessions as well.Are there any other relations where we want this to happen? I'm thinking of sessions referencing users (do we ever want to delete users?) etc.