Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few build fixes #1254

Merged
merged 7 commits into from
Jul 2, 2024
Merged

Conversation

rrw-zilliqa
Copy link
Contributor

(fix) Add emacs backups to .gitignore
(fix) A tiny bit more documentation
(feat) respect VCPKG_ALWAYS_INSTALL
(fix) The protobuf library now appears to want curried arguments.

Closes #1253

(fix) A tiny bit more documentation
(feat) respect VCPKG_ALWAYS_INSTALL
(fix) The protobuf library now appears to want curried arguments.
Copy link

@JamesHinshelwood JamesHinshelwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is using a different version of the pbrt dependency that doesn't want its arguments curried:

#27 311.1 File "src/eval/Ipcmessage_pb.ml", line 114, characters 4-23:
#27 311.1 114 |     Pbrt.Encoder.nested encode_proto_scilla_val x encoder
#27 311.1           ^^^^^^^^^^^^^^^^^^^
#27 311.1 Error: This function has type
#27 311.1          (Pbrt.Encoder.t -> unit) -> Pbrt.Encoder.t -> unit
#27 311.1        It is applied to too many arguments; maybe you forgot a `;'.

Copy link
Contributor

@mauromedda mauromedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rrw-zilliqa rrw-zilliqa merged commit de22052 into main-zq2 Jul 2, 2024
2 checks passed
@rrw-zilliqa rrw-zilliqa deleted the users/richard/scilla-build-and-docs branch July 2, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants