Pass health checks if any block is produced #1631
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the check only passed if the latest returned block was greater than the previous one. Occasionally, we reset the devnet to an earlier block. This causes all the health checks to fail. So instead we just assert that the 'latest' block has changed within the last 60 seconds, even if the block number has decreased.
DrZoltanFazekas
approved these changes
Oct 14, 2024
Any commits made after this event will not be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the check only passed if the latest returned block was greater than the previous one. Occasionally, we reset the devnet to an earlier block. This causes all the health checks to fail. So instead we just assert that the 'latest' block has changed within the last 60 seconds, even if the block number has decreased.