-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Added es and cerebro services, rudimentary unstract-metrics lib added #473
base: main
Are you sure you want to change the base?
WIP: Added es and cerebro services, rudimentary unstract-metrics lib added #473
Conversation
unstract/metrics/README.md
Outdated
``` | ||
|
||
|
||
## Using Cerebro: An Elasticsearch Web Admin tool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chandrasekharan-zipstack Create a confluence page for Cerebro no need to include here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jaseemjaskp Wondering if we should mention it in README so that users can install for admin tasks if they wish? Are there any other recommended tools?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hari-kuriakose kibana maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hari-kuriakose @chandrasekharan-zipstack Elasicsearch official one is Kibana. we can mention that in readme if required. https://github.com/lmenezes/cerebro is not up to date with official ES.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jaseemjaskp if cerebro is not upto date with official ES do you think we should also try kibana?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chandrasekharan-zipstack try out Kibana. but no need into include in docker-compose file
Quality Gate passedIssues Measures |
Quality Gate passedIssues Measures |
Quality Gate passedIssues Measures |
|
What
es
andcerebro
services as part of the optional profileunstract-metrics
unstract-metrics
library that wraps elasticsearch_dsl to add and query metricsNOTE: Understood now that index creation need not happen through the regular code flow so some of the changes here would be invalid, will continue my development assuming that the index is already created and focus on exposing methods to aid easier collection of metrics for each sub-process / process type
How
Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)
Env Config
Relevant Docs
Dependencies Versions
elasticsearch-dsl~=8.14.0
but not included in any existing services yetNotes on Testing
Screenshots
Checklist
I have read and understood the Contribution Guidelines.