-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/oracle-db-connector-with-refactoring-db-connectors #606
Conversation
…CBN-Add-Oracle-connector
…CBN-Add-Oracle-connector
…CBN-Add-Oracle-connector
unstract/connectors/src/unstract/connectors/databases/bigquery/bigquery.py
Show resolved
Hide resolved
…stack/unstract into UN-1582-ABS-CBN-Add-Oracle-connector
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - left some minor comments
unstract/connectors/src/unstract/connectors/databases/oracle-db/oracle_db.py
Outdated
Show resolved
Hide resolved
unstract/connectors/src/unstract/connectors/databases/oracle-db/static/json_schema.json
Outdated
Show resolved
Hide resolved
unstract/connectors/src/unstract/connectors/databases/oracle-db/static/json_schema.json
Outdated
Show resolved
Hide resolved
…stack/unstract into UN-1582-ABS-CBN-Add-Oracle-connector
unstract/connectors/src/unstract/connectors/databases/bigquery/bigquery.py
Outdated
Show resolved
Hide resolved
unstract/connectors/src/unstract/connectors/databases/oracle-db/oracle_db.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, Added Some minor comments. also please check the pre-commit issues .
…stack/unstract into UN-1582-ABS-CBN-Add-Oracle-connector
|
Quality Gate failedFailed conditions |
Duplication will be handled once Django apps v1 is removed later. |
What
Why
How
Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)
Database Migrations
Env Config
Relevant Docs
Related Issues or PRs
Dependencies Versions
Notes on Testing
Screenshots
Checklist
I have read and understood the Contribution Guidelines.