Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/mrq filter by low confidence #850

Merged
merged 18 commits into from
Dec 17, 2024
Merged

Feat/mrq filter by low confidence #850

merged 18 commits into from
Dec 17, 2024

Conversation

vishnuszipstack
Copy link
Contributor

What

  • Placeholder function in workflow utils
  • Prompt studio registry urls and view update to get prompt registry details
  • FE changes for DB rules MRQ

Why

  • DB rules MRQ

How

  • Check details in related Cloud PR

Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)

  • NO

Database Migrations

Env Config

Relevant Docs

Related Issues or PRs

Dependencies Versions

Notes on Testing

Screenshots

Checklist

I have read and understood the Contribution Guidelines.

muhammad-ali-e
muhammad-ali-e approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@muhammad-ali-e muhammad-ali-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the comments from @chandrasekharan-zipstack . LGTM

@vishnuszipstack @jagadeeswaran-zipstack
Update frontend/src/components/agency/configure-connector-modal/Confi…
37c3db4 
…gureConnectorModal.jsx

Co-authored-by: jagadeeswaran-zipstack <[email protected]>
Signed-off-by: vishnuszipstack <[email protected]>
harini-venkataraman
harini-venkataraman approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@harini-venkataraman harini-venkataraman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added a minor comment

@github-actions GitHub Actions
Copy link
Contributor

filepath function $$\textcolor{#23d18b}{\tt{passed}}$$ SUBTOTAL
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_logs}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_cleanup}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_cleanup\_skip}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_client\_init}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_get\_image\_exists}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_get\_image}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_get\_container\_run\_config}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_get\_container\_run\_config\_without\_mount}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{worker/src/unstract/worker/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_run\_container}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{TOTAL}}$$ $$\textcolor{#23d18b}{\tt{9}}$$ $$\textcolor{#23d18b}{\tt{9}}$$

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.7% Duplication on New Code

See analysis details on SonarQube Cloud

@vishnuszipstack vishnuszipstack merged commit 8a01ca2 into main Dec 17, 2024
6 checks passed
@vishnuszipstack vishnuszipstack deleted the feat/mrq-filter-by-low-confidence branch December 17, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muhammad-ali-e muhammad-ali-e muhammad-ali-e approved these changes

@harini-venkataraman harini-venkataraman harini-venkataraman approved these changes

@jagadeeswaran-zipstack jagadeeswaran-zipstack jagadeeswaran-zipstack approved these changes

@Deepak-Kesavan Deepak-Kesavan Deepak-Kesavan approved these changes

@kirtimanmishrazipstack kirtimanmishrazipstack Awaiting requested review from kirtimanmishrazipstack kirtimanmishrazipstack was automatically assigned from Zipstack/unstract-reviewers-l1

@tahierhussain tahierhussain Awaiting requested review from tahierhussain

@johnyrahul johnyrahul Awaiting requested review from johnyrahul

@chandrasekharan-zipstack chandrasekharan-zipstack Awaiting requested review from chandrasekharan-zipstack

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vishnuszipstack @Deepak-Kesavan @jagadeeswaran-zipstack @harini-venkataraman @chandrasekharan-zipstack @muhammad-ali-e