-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First version of file Execution model #891
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - left some minor comments
backend/workflow_manager/file_execution/file_execution_helper.py
Outdated
Show resolved
Hide resolved
backend/workflow_manager/file_execution/file_execution_helper.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - left a minor comment
|
Quality Gate passedIssues Measures |
Migration looks good overall. |
What
UN-1891
Introduce a FileExecution Model
Refactor in source.py
Set
runId
asID
of FileExecution instaed of generating a new UUID.Set
use_file_history=True
for ETL and Task Execution to avoid unnecessary re-executions.Why
How
Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)
Database Migrations
Env Config
Relevant Docs
Related Issues or PRs
Dependencies Versions
Notes on Testing
Screenshots
Checklist
I have read and understood the Contribution Guidelines.