Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove branch isolation #1353

Merged
merged 6 commits into from
Nov 9, 2023
Merged

Remove branch isolation #1353

merged 6 commits into from
Nov 9, 2023

Conversation

dark64
Copy link
Member

@dark64 dark64 commented Oct 23, 2023

This feature turned out to be expensive and buggy in some cases. After a discussion with @Schaeff, we decided to remove the experimental feature for now.

@dark64 dark64 requested a review from Schaeff November 9, 2023 11:58
Copy link
Member

@Schaeff Schaeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very small suggestion

zokrates_codegen/src/lib.rs Show resolved Hide resolved
@dark64 dark64 requested a review from Schaeff November 9, 2023 12:53
@Schaeff Schaeff merged commit f102933 into develop Nov 9, 2023
8 checks passed
dark64 added a commit that referenced this pull request Nov 9, 2023
* remove branch isolation

* update book, add changelog

* clippy

* revert clippy suggestion

* move clippy allow rule to root lib.rs

* derive default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants