fix: audit feedback (#99)

* fix: remove commented code

* fix: replace unwrap with map_err

* chore: bump version

* chore: snapshots

app/.cargo/config.toml

@@ -1,6 +1,6 @@
 [env]
 HEAP_SIZE = "16384"
-APPVERSION = "1.1.0"
+APPVERSION = "1.1.1"
 
 [unstable]
 build-std = ["core", "alloc"]

app/src/app_ui/menu.rs

@@ -59,7 +59,6 @@ pub fn ui_menu_main(comm: &mut Comm) -> Event<Instruction> {
             false => "Disabled",
         };
 
-        // app_version = String::from("x");
         let pages = [
             &Page::from((_first_page_label, &APP_ICON)),
             &Page::from((["Expert Mode", expert_mode_label], true, true)),

app/src/crypto/chacha20poly.rs

@@ -76,9 +76,9 @@ pub fn compute_key() -> EncryptionKeyGuard {
     let path_0: Vec<u32> = vec![
         (0x80000000 | 0x2c),
         (0x80000000 | 0x53a),
-        (0x80000000), // (0x80000000 | 0x0)
-        (0x80000000), // (0x80000000 | 0x0)
-        (0x80000000), // (0x80000000 | 0x0)
+        (0x80000000),
+        (0x80000000),
+        (0x80000000),
     ];
 
     let mut secret_key_0 = Secret::<ED25519_KEY_LEN>::new();

app/src/crypto/keys.rs

@@ -111,15 +111,15 @@ pub(crate) fn compute_dkg_secret(index: u8) -> IronfishSecretGuard {
     let path_0: Vec<u32> = vec![
         (0x80000000 | 0x2c),
         (0x80000000 | 0x53a),
-        (0x80000000), // (0x80000000 | 0x0)
-        (0x80000000), // (0x80000000 | 0x0)
+        (0x80000000),
+        (0x80000000),
         (0x80000000 | index_1),
     ];
     let path_1: Vec<u32> = vec![
         (0x80000000 | 0x2c),
         (0x80000000 | 0x53a),
-        (0x80000000), // (0x80000000 | 0x0)
-        (0x80000000), //(0x80000000 | 0x0)
+        (0x80000000),
+        (0x80000000),
         (0x80000000 | index_2),
     ];
 

app/src/token.rs

@@ -22,11 +22,9 @@ pub struct TokenInfo<'a> {
 }
 
 pub fn get_token_list() -> Result<TokenList<'static>, ParserError> {
-    let t = serde_json_core::from_str::<TokenList>(TOKEN_LIST)
+    serde_json_core::from_str::<TokenList>(TOKEN_LIST)
         .map(|(t, _)| t)
-        .unwrap();
-    // .map_err(|_| ParserError::InvalidTokenList)?;
-    Ok(t)
+        .map_err(|_| ParserError::InvalidTokenList)
 }
 
 impl<'a> TokenList<'a> {

tests_zemu/tests/basic.test.ts

@@ -59,7 +59,7 @@ describe('Basic', function () {
       expect(resp.testMode).toBe(false)
       expect(resp.major).toBe(1)
       expect(resp.minor).toBe(1)
-      expect(resp.patch).toBe(0)
+      expect(resp.patch).toBe(1)
     } finally {
       await sim.close()
     }