Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable more tests #7

Merged
merged 13 commits into from
Oct 2, 2024
Merged

Enable more tests #7

merged 13 commits into from
Oct 2, 2024

Conversation

nodh
Copy link
Contributor

@nodh nodh commented Sep 25, 2024

Builds upon a-sit-plus/vck#136, probably resolving #6?

@nodh nodh self-assigned this Sep 25, 2024
Copy link
Contributor

@JesusMcCloud JesusMcCloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we really want that to go into main. this composite build requiring it to be a subdirectory of VC-K? if we didn't need this credential to align perfectly with VC-K for testing, we could just update smoothly whenever needed after a VC-K release…

@nodh
Copy link
Contributor Author

nodh commented Sep 26, 2024

do we really want that to go into main. this composite build requiring it to be a subdirectory of VC-K? if we didn't need this credential to align perfectly with VC-K for testing, we could just update smoothly whenever needed after a VC-K release…

No ... i've just used your open branch as the base

@JesusMcCloud
Copy link
Contributor

JesusMcCloud commented Sep 27, 2024

pending everything's green, this is now the preparation for the next release. @nodh pull this into the vc-k release as test dependency yourself, when you prepare it.

this credentials still needs one final commit to update to stable vc-k and remove the SNAPSHOT suffix. before it can be released. Then: squash, merge, and release at your discretion. I'll handle the other credentials.

@JesusMcCloud JesusMcCloud merged commit ab6bcc7 into main Oct 2, 2024
3 checks passed
@nodh nodh mentioned this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants