Secure hashing to curve per RFC9380 #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I hate to overcomplicate things, but I really think we need some additional interface on an elliptic curve class to denote which ones work for our current EC math and which ones don't. Currently, all curves work, but this will change in the future. If we add this now, its harder to shoot your future self in the foot |
|
yes, i've thought about this as well; would mean refactoring the |
i don't think this is relevant to this PR though; it would be a separate refactor |
JesusMcCloud
requested changes
Oct 25, 2024
supreme/src/commonMain/kotlin/at/asitplus/signum/ecmath/RFC9380.kt
Outdated
Show resolved
Hide resolved
supreme/src/commonMain/kotlin/at/asitplus/signum/ecmath/RFC9380.kt
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
|
made the requested changes |
JesusMcCloud
approved these changes
Oct 28, 2024
- RFC9380.expand_message_xmd - RFC9380.map_to_curve_simple_swu they are sometimes used as components in other constructions
JesusMcCloud
pushed a commit
that referenced
this pull request
Nov 7, 2024
JesusMcCloud
pushed a commit
that referenced
this pull request
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC. This is needed for lots of advanced cryptography, including OPRFs and OPAQUE. Probably a good thing to have in one place.
Note: side channel security relies on the underlying BigInteger implementation being constant time. I have my doubts whether our underlying BigInteger is constant time.