Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web3_clientVersion): Adds RPC method to fetch client version #414

Merged
merged 6 commits into from
Oct 31, 2024

Conversation

mw2000
Copy link
Contributor

@mw2000 mw2000 commented Oct 29, 2024

We add the RPC method to fetch the client version via web3_clientVersion. This is also the get_client_version function while calling from a the rust client. Tested with function call in examples/basic.rs.

This should tackle #412

We add the RPC method to fetch the client version via web3_clientVersion. This is also the get_client_version function while calling from a the rust client. Tested with function call in examples/basic.rs. This should tackle a16z#412
core/src/execution/mod.rs Outdated Show resolved Hide resolved
@mw2000 mw2000 requested a review from ncitron October 30, 2024 02:19
core/src/execution/mod.rs Outdated Show resolved Hide resolved
core/src/client/rpc.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@ncitron ncitron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ncitron ncitron merged commit 50a315f into a16z:master Oct 31, 2024
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants