Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuget #114

Merged
merged 6 commits into from
Dec 13, 2019
Merged

Nuget #114

merged 6 commits into from
Dec 13, 2019

Conversation

nickntg
Copy link
Contributor

@nickntg nickntg commented Nov 1, 2019

This might help to get started with nuget (see #46).

Before being able to run publish_nuget.cmd you'll need to create an account in nuget.org.

n.bitounis added 2 commits November 1, 2019 23:45
…g it as a separate file having to be carried around in the nuget.
…ithms output directory.

* Added a script to create the nuget and publish it to nuget.org.
@aalhour
Copy link
Owner

aalhour commented Nov 2, 2019

Hi @nickntg,

Thanks for the addition. Please read the Contributor's Guide before submitting Pull Requests. There should be an issue for any proposed change. Ideally, we will discuss the issue there first and then move to a pull request.

@PatrykOlejniczak
Copy link
Collaborator

Hello @nickntg

Can you split this into 2 separate pr one for nuget and other one for Primes list fix?

Greetings

@nickntg
Copy link
Contributor Author

nickntg commented Nov 10, 2019

Yeah, I can do that. I did that in order to ensure that everything stays packed in the library and there is no need to add the data folder in the nuget. Still want me to do it?

Copy link
Owner

@aalhour aalhour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nickntg,

I think what @PatrykOlejniczak meant is that it would be better to have one separate PR for the Primes fix and another PR for the Nuget Spec. Two PRs in total. One for each change. Could you please do that? We can keep this PR for the Primes fix so you only have to move the Nuget Spec into a new separate PR.

Cheers,
Ahmad

@PatrykOlejniczak
Copy link
Collaborator

Yea, i meant, one pr = one change (one issue), just to make pr small/easy to review :)

@aalhour
Copy link
Owner

aalhour commented Nov 15, 2019

@nickntg - any updated from your side?

@aalhour aalhour added the feature Suggest a new idea for this project label Nov 15, 2019
@nickntg
Copy link
Contributor Author

nickntg commented Nov 17, 2019

@aalhour Sure, will do and submit new PRs.

@aalhour
Copy link
Owner

aalhour commented Nov 28, 2019

@nickntg - now that #124 is merged, please clean up this PR and make sure it only contains the changes relevant to Nuget publishing.

n.bitounis added 4 commits December 1, 2019 21:49
…he algorithms output directory."

This reverts commit 8aef6ec.
…id having it as a separate file having to be carried around in the nuget."

This reverts commit 100563f.
@nickntg
Copy link
Contributor Author

nickntg commented Dec 1, 2019

@aalhour Done. However, this works on windows machines only...

@aalhour aalhour merged commit 14392dc into aalhour:master Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Suggest a new idea for this project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants