-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nuget #114
Nuget #114
Conversation
…g it as a separate file having to be carried around in the nuget.
…ithms output directory. * Added a script to create the nuget and publish it to nuget.org.
Hi @nickntg, Thanks for the addition. Please read the Contributor's Guide before submitting Pull Requests. There should be an issue for any proposed change. Ideally, we will discuss the issue there first and then move to a pull request. |
Hello @nickntg Can you split this into 2 separate pr one for nuget and other one for Primes list fix? Greetings |
Yeah, I can do that. I did that in order to ensure that everything stays packed in the library and there is no need to add the data folder in the nuget. Still want me to do it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nickntg,
I think what @PatrykOlejniczak meant is that it would be better to have one separate PR for the Primes fix and another PR for the Nuget Spec. Two PRs in total. One for each change. Could you please do that? We can keep this PR for the Primes fix so you only have to move the Nuget Spec into a new separate PR.
Cheers,
Ahmad
Yea, i meant, one pr = one change (one issue), just to make pr small/easy to review :) |
@nickntg - any updated from your side? |
@aalhour Sure, will do and submit new PRs. |
@aalhour Done. However, this works on windows machines only... |
This might help to get started with nuget (see #46).
Before being able to run publish_nuget.cmd you'll need to create an account in nuget.org.