update and reconcile changes

aamgayle · Oct 20, 2023 · f42d266 · f42d266
1 parent c407260
commit f42d266
Showing 1 changed file with 16 additions and 6 deletions.
diff --git a/pkg/controller/keyvault/ingress_secret_provider_class_test.go b/pkg/controller/keyvault/ingress_secret_provider_class_test.go
@@ -164,12 +164,6 @@ func TestIngressSecretProviderClassReconcilerIntegrationWithoutSPCLabels(t *test
 	ctx := context.Background()
 	ctx = logr.NewContext(ctx, logr.Discard())
 
-	spc := &secv1.SecretProviderClass{}
-	spc.Name = "keyvault-" + ing.Name
-	spc.Namespace = ing.Namespace
-	require.NoError(t, c.Get(ctx, client.ObjectKeyFromObject(spc), spc))
-	spc.Labels = map[string]string{}
-
 	// Create the secret provider class
 	req := ctrl.Request{NamespacedName: types.NamespacedName{Namespace: ing.Namespace, Name: ing.Name}}
 	beforeErrCount := testutils.GetErrMetricCount(t, ingressSecretProviderControllerName)
@@ -180,6 +174,22 @@ func TestIngressSecretProviderClassReconcilerIntegrationWithoutSPCLabels(t *test
 	require.Equal(t, testutils.GetErrMetricCount(t, ingressSecretProviderControllerName), beforeErrCount)
 	require.Greater(t, testutils.GetReconcileMetricCount(t, ingressSecretProviderControllerName, metrics.LabelSuccess), beforeRequestCount)
 
+	// Prove it exists
+	spc := &secv1.SecretProviderClass{}
+	spc.Name = "keyvault-" + ing.Name
+	spc.Namespace = ing.Namespace
+	spc.Labels = map[string]string{}
+	require.NoError(t, i.client.Update(ctx, spc))
+
+	beforeErrCount = testutils.GetErrMetricCount(t, ingressSecretProviderControllerName)
+	beforeRequestCount = testutils.GetReconcileMetricCount(t, ingressSecretProviderControllerName, metrics.LabelSuccess)
+	_, err = i.Reconcile(ctx, req)
+	require.NoError(t, err)
+	require.Equal(t, testutils.GetErrMetricCount(t, ingressSecretProviderControllerName), beforeErrCount)
+	require.Greater(t, testutils.GetReconcileMetricCount(t, ingressSecretProviderControllerName, metrics.LabelSuccess), beforeRequestCount)
+
+	require.NoError(t, c.Get(ctx, client.ObjectKeyFromObject(spc), spc))
+
 	// Test should never hit the lines in buildSPC to create the Spec so it should be nil
 	assert.Equal(t, spc.Spec, nil)
 	assert.Equal(t, len(spc.Labels), 0)