Development #58
Merged
Development #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
aaronparker
commented
Sep 22, 2024
aaronparker
commented
- Update output message for more verbosity
- Fix paths and copy into package for the PSAppDeployToolkit
- Fix issue with icon path when icon does not exist
changed that if detection via script is used, the detectionscript will be taken from the app direcotry instead of main\scripts path.
Added Comparison of Version as [version] object to ensure correct handling of subversions. $a = "5.15.5.19404" $b = "5.15.11.21032" [version]$a -gt [version]$b False <- correct $a -gt $b True <- wrong
if application.filter is set to "" - it's not null but still empty
added fix that icon url can be empty
Signed-off-by: kenchan0130 <[email protected]>
Update Create-Win32App.ps1
Add Verbose flag to show the download source URL
Fix New-IntuneWin32AppPackage using PSAppDeployToolkit
Update output
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } else { | ||
| $AppIconFile = $null | ||
| } | ||
|
|
Check notice
Code scanning / PSScriptAnalyzer
Line has trailing whitespace Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.