Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct VC++ 2013 12.0.30501.0 x86 Product Code #175

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

amorrowbellarmine
Copy link
Contributor

Description

The product code for VC++ 2013 12.0.30501.0 x86 is {f65db027-aff3-4070-886a-0d87064aabb1} . It looks like there was a copy/paste mistake because it was set to the same code as the x64 installer.

Motivation and Context

The detection rules for SCCM and Intune incorrectly check for the x64 product code instead of the x86 product code.

Screenshots (if appropriate):

image
Winget's manifest file: https://github.com/microsoft/winget-pkgs/blob/master/manifests/m/Microsoft/VCRedist/2013/x86/12.0.30501.0/Microsoft.VCRedist.2013.x86.installer.yaml

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have updated the CHANGELOG file accordingly for the version that this merge modifies.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

The product code for VC++ 2013 x86 12.0.30501.0 is {f65db027-aff3-4070-886a-0d87064aabb1} . Looks like there was a copy/paste mistake because it was set the same code as the x64 installer.
@aaronparker aaronparker merged commit a670adc into aaronparker:main Dec 4, 2024
1 check passed
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.41%. Comparing base (faf139c) to head (883e96d).
Report is 8 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #175   +/-   ##
=======================================
  Coverage   69.41%   69.41%           
=======================================
  Files          24       24           
  Lines         788      788           
=======================================
  Hits          547      547           
  Misses        241      241           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ada735b...883e96d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants