Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metamodel version 3.1 support #308

Merged
merged 6 commits into from
Feb 19, 2024
Merged

Add metamodel version 3.1 support #308

merged 6 commits into from
Feb 19, 2024

Conversation

s-heppner
Copy link
Collaborator

This is the branch where all the changes regarding v3.1 will be introduced.
As a final step, we should merge this branch into main.

@s-heppner s-heppner added the V3.1 SpecAAS V3.1 label Feb 15, 2024
@s-heppner s-heppner added this to the V3.1 milestone Feb 15, 2024
@s-heppner s-heppner marked this pull request as draft February 15, 2024 08:56
We add `v3_1.py` and adapt the version number wherever we found.
This commit adds tests for `v3_1.py`.
When changing the module from `v3` to `v3_1`, the name obviously
got two characters longer.
This resulted in overstepping the maximum line limit in two
occasions.
We fix this oversight with this commit.
A new enumeration value has been added to class `Asset_kind`, see
[aas-specs#294](admin-shell-io/aas-specs#294)

Fixes #302
Previously, the `matches_id_short` regular expression only allowed
letters, digits and underscores.

With the decision of
[aas-specs#295](admin-shell-io/aas-specs#295),
this condition was relaxed to allow also hyphens.

Fixes #304
Previously, `Entity.entity_type` was mandatory, however v3.1
changes this.
We adapt the class defintion, as well as the invariant of AASd-014.

Fix #306
@s-heppner s-heppner marked this pull request as ready for review February 19, 2024 08:14
@s-heppner s-heppner requested a review from zrgt February 19, 2024 08:14
Copy link
Collaborator

@zrgt zrgt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@s-heppner s-heppner merged commit 3f01c13 into main Feb 19, 2024
2 checks passed
@s-heppner s-heppner deleted the V3.1/main branch February 19, 2024 08:18
@s-heppner s-heppner changed the title [WIP] Add metamodel version 3.1 support Add metamodel version 3.1 support Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V3.1 SpecAAS V3.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants