Make Path_type match xs:AnyUri
#322
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was necessary because the type of file has changed from file to patch type and the wrong rfc for xml 1.1 any uri was given in the pdf specification which was adapted for xml schmea 1.0
matches_RFC_8089_path is no longer needed in Spec
mristin
requested changes
Mar 10, 2024
| @@ -1239,6 +1193,10 @@ class Non_empty_XML_serializable_string(str, DBC): | |||
|
|
|||
| An attribute with data type "string" shall consist of these characters only: | |||
| ``^[\x09\x0A\x0D\x20-\uD7FF\uE000-\uFFFD\u00010000-\u0010FFFF]*$``. | |||
|
|
|||
| Constraint AASd-130 ensures that encoding and interoperability between | |||
There was a problem hiding this comment.
I suppose this needs to go in a separate pull request as it is an unrelated change?
| Any string conformant to RFC8089 , the “file” URI scheme (for | ||
| relative and absolute file paths) | ||
| Any string conformant to RFC 2396 and amended by RFC 2732, the “file” URI scheme | ||
| for XSL Schema 1.0 relative and absolute file paths |
There was a problem hiding this comment.
Suggested change
| for XSL Schema 1.0 relative and absolute file paths | |
| for XSD 1.0 relative and absolute file paths |
I suppose XSL is a typo?
|
@g1zzm0 please don't forget to change the commit message to the pull request description when you squash & merge (or alternatively, shoot me an email so that I can merge). |
|
I also see that the CI fails -- have you run the formatting on your side? In the virtual environment, you can simply run: |
|
I'm closing this issue to avoid the confusion. The change from the Path to xs:anyURI is (most probably) expected in V3.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In V3.1, the path type is changed, so that it does not conform anymore to RFC 8089 (paths in filesystems), but conforms to an URI (i.e.,
xs:anyURI). Moreover, we also adapt the documentation to refer to XML schema 1.0 instead of 1.1, according to the book.