Add verifcation function for RFC 2396, adapt Path_type #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I still seem to have some issues with the regular expression provided with abnf_to_regexp: |
s-heppner
changed the title
Version 3.1 of the metamodel changes the `Path_type` to be conforming to RFC 2396 (see [spec-link]). As we did not have a verifcation function for this RFC, we add the function `matches_RFC_2396` based on this [abnf_to_regexp test case] and adapt the `Path_type` invariant accordingly. [spec-link](https://admin-shell-io.github.io/aas-specs-antora/IDTA-01001/v3.1/spec-metamodel/datatypes.html#PathType) [abnf_to_regexp test case](https://github.com/aas-core-works/abnf-to-regexp/blob/main/test_data/nested-python/rfc2396/expected.py)
s-heppner
force-pushed
the
Add/RFC2396
branch
from
666e5da
to
ee8702e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 3.1 of the metamodel changes the
Path_typeto be conforming to RFC 2396 (see spec-link ).As we did not have a verifcation function for this RFC, we add the function
matches_RFC_2396based on this abnf_to_regexp test case and adapt thePath_typeinvariant accordingly.