Skip to content

Commit

Permalink
Update to aas-core-meta, codegen, testgen f9cbdb3, b14237b2, 5a705a0b1 (
Browse files Browse the repository at this point in the history
#39)

We update the development requirements to and re-generate everything
with:
* [aas-core-meta f9cbdb3],
* [aas-core-codegen b14237b2] and
* [aas-core3.0-testgen 5a705a0b1].

Notably, we propagate the fix for AASd-109 where we change the invariant
such that it checks for the consistency among properties even when
a ``value`` property is missing.

[aas-core-meta f9cbdb3]: aas-core-works/aas-core-meta@f9cbdb3
[aas-core-codegen b14237b2]: aas-core-works/aas-core-codegen@b14237b2
[aas-core3.0-testgen 5a705a0b1]: aas-core-works/aas-core3.0-testgen@5a705a0b1
  • Loading branch information
mristin authored Aug 31, 2024
1 parent 4ec6a73 commit 051a46c
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 20 deletions.
2 changes: 1 addition & 1 deletion _dev_scripts/aas_core3/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
This copy is necessary so that we can decouple from ``aas-core*-python`` repository.
The revision of aas-core-codegen was: 0f7345e1
The revision of aas-core-codegen was: b14237b2
"""
20 changes: 10 additions & 10 deletions _dev_scripts/aas_core3/verification.py
Original file line number Diff line number Diff line change
Expand Up @@ -3426,21 +3426,21 @@ def transform_submodel_element_list(
if not (
not (
(
(that.value is not None)
and (
(
that.type_value_list_element == aas_types.AASSubmodelElements.PROPERTY
or that.type_value_list_element == aas_types.AASSubmodelElements.RANGE
)
)
that.type_value_list_element == aas_types.AASSubmodelElements.PROPERTY
or that.type_value_list_element == aas_types.AASSubmodelElements.RANGE
)
)
or (
(
(that.value_type_list_element is not None)
and properties_or_ranges_have_value_type(
that.value,
that.value_type_list_element
and (
(
(that.value is None)
or properties_or_ranges_have_value_type(
that.value,
that.value_type_list_element
)
)
)
)
)
Expand Down
4 changes: 2 additions & 2 deletions _dev_scripts/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@
keywords="asset administration shell code generation industry 4.0 industrie i4.0",
install_requires=[
"icontract>=2.6.1,<3",
"aas-core-meta@git+https://github.com/aas-core-works/aas-core-meta@31d6afd#egg=aas-core-meta",
"aas-core-codegen@git+https://github.com/aas-core-works/aas-core-codegen@0f7345e1#egg=aas-core-codegen",
"aas-core-meta@git+https://github.com/aas-core-works/aas-core-meta@f9cbdb3#egg=aas-core-meta",
"aas-core-codegen@git+https://github.com/aas-core-works/aas-core-codegen@b14237b2#egg=aas-core-codegen",
],
# fmt: off
extras_require={
Expand Down
14 changes: 7 additions & 7 deletions verification/verification.go
Original file line number Diff line number Diff line change
Expand Up @@ -5177,14 +5177,14 @@ func VerifySubmodelElementList(
}
}

if !(!((that.Value() != nil) &&
(that.TypeValueListElement() == aastypes.AASSubmodelElementsProperty ||
that.TypeValueListElement() == aastypes.AASSubmodelElementsRange)) ||
if !(!(that.TypeValueListElement() == aastypes.AASSubmodelElementsProperty ||
that.TypeValueListElement() == aastypes.AASSubmodelElementsRange) ||
((that.ValueTypeListElement() != nil) &&
PropertiesOrRangesHaveValueType(
that.Value(),
*that.ValueTypeListElement(),
))) {
((that.Value() == nil) ||
PropertiesOrRangesHaveValueType(
that.Value(),
*that.ValueTypeListElement(),
)))) {
abort = onError(
newVerificationError(
"Constraint AASd-109: If type value list element is equal to " +
Expand Down

0 comments on commit 051a46c

Please sign in to comment.