Fix XML deserialization for over-consumption #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mristin
force-pushed
the
mristin/Fix-XML-deserialization-for-discriminator
branch
from
74adb43 to
0c3ecf0
Compare
We read a token too much in `unmarshalXxx` functions. The bug went unnoticed as all our examples used indented XML, which eclipsed the over-consumption. In this patch, we remove the `unmarshalXxx`, as they turn out to be redundant, and use `readXxxWithLookahead` to appropriately read the tokens without over-consumption. Fixes #24.
mristin
force-pushed
the
mristin/Fix-XML-deserialization-for-discriminator
branch
from
0c3ecf0 to
c50225f
Compare
Closed
Merged
mristin
added a commit
that referenced
this pull request
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We read a token too much in
unmarshalXxxfunctions. The bug went unnoticed as all our examples used indented XML, which eclipsed the over-consumption.In this patch, we remove the
unmarshalXxx, as they turn out to be redundant, and usereadXxxWithLookaheadto appropriately read the tokens without over-consumption.Fixes #24.