Simplify tests for splits in negative test data #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We propagate the split of negative samples in [aas-core3.0-testgen 08d3ec37c] into unserializable and invalid negative examples. This makes the generation and future maintenance of the test code easier in this SDK as well, since we now do not have to track the individual negative cases. In addition, we improve the error messages if the recorded test data is missing to make it clearer for the programmer what needs to be fixed in that case. [aas-core3.0-testgen 08d3ec37c]: aas-core-works/aas-core3.0-testgen@08d3ec37c
mristin
force-pushed
the
mristin/Simplify-tests-for-splits-in-negative-test-data
branch
from
fd68e41 to
717b8d6
Compare
mristin
deleted the
mristin/Simplify-tests-for-splits-in-negative-test-data
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We propagate the split of negative samples in
aas-core3.0-testgen 08d3ec37c into unserializable and invalid negative examples. This makes the generation and future maintenance of the test code easier in this SDK as well, since we now do not have to track the individual negative cases.
In addition, we improve the error messages if the recorded test data is missing to make it clearer for the programmer what needs to be fixed in that case.