Check explicitly for invalid model types #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We explicitly check during the JSON de-serialization that model types correspond to the expected model types. We need to be particularly careful with concrete classes without descendants with a mandatory ``modelType``, as they do not necessarily require a model type for de-serialization, but the specs mandate it for reasons of backward compatibility. The code corresponds to [aas-core-codegen 56482d65], and the test data corresponds to [aas-core3.0-testgen 9e523511c]. This is related to the issue [aas-core3.0-python #32], which discovered the problematic in the first place. [aas-core-codegen 56482d65]: aas-core-works/aas-core-codegen@56482d65 [aas-core3.0-testgen 9e523511c]: aas-core-works/aas-core3.0-testgen@9e523511c [aas-core3.0-python #32]: aas-core-works/aas-core3.0-python#32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We explicitly check during the JSON de-serialization that model types correspond to the expected model types. We need to be particularly careful with concrete classes without descendants with a mandatory
modelType, as they do not necessarily require a model type for de-serialization, but the specs mandate it for reasons of backward compatibility.The code corresponds to aas-core-codegen 56482d65, and the test data corresponds to aas-core3.0-testgen 9e523511c.
This is related to the issue aas-core3.0-python #32, which discovered the problematic in the first place.