Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tune TokenPool contracts to make it compatible with gho-core #1

Merged
merged 2 commits into from
Apr 5, 2024

Conversation

miguelmtzinf
Copy link

Modifications:

  • Soften Solidity compiler version of TokenPool contracts to ^0.8.0 so they are compatible with gho-core.
  • Remove named parameters in mapping types (as it was introduced in v0.8.18).
  • Makes _transferOwnership internal instead of private so it's possible to initialize the owner outside the constructor.

Copy link

height bot commented Apr 5, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link

github-actions bot commented Apr 5, 2024

LCOV of commit 861a21b during Solidity Foundry #1

Summary coverage rate:
  lines......: 98.7% (936 of 948 lines)
  functions..: 95.6% (196 of 205 functions)
  branches...: 91.9% (364 of 396 branches)

Files changed coverage rate: n/a

@miguelmtzinf miguelmtzinf merged commit 4550cf6 into ccip-gho Apr 5, 2024
30 of 45 checks passed
@miguelmtzinf miguelmtzinf deleted the fix/tokenpool-tune branch April 5, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant