GHO CCIP 1.5 Token Pool #19
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
||
| /// @dev Constructor | ||
| /// @param token The bridgeable token that is managed by this pool. | ||
| /// @param rmnProxy The address of the arm proxy |
There was a problem hiding this comment.
Small nit: but now that it's called rmn instead of arm, perhaps we should change the second part of this comment to match
| /// @param owner_ The address of the owner | ||
| /// @param allowlist A set of addresses allowed to trigger lockOrBurn as original senders | ||
| /// @param router The address of the router | ||
| function initialize(address owner_, address[] memory allowlist, address router) public virtual initializer { |
There was a problem hiding this comment.
We don't usually like putting _ in function params, suggested to use owner instead of owner_. Also @param comment to match
| /// @param router The address of the router | ||
| /// @param bridgeLimit The maximum amount of tokens that can be bridged to other chains | ||
| function initialize( | ||
| address owner_, |
There was a problem hiding this comment.
Same as above comment on _ in variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.